jeffpc commented on this pull request.


> +     lua_pushlightuserdata(state, &ri);
+       lua_setfield(state, LUA_REGISTRYINDEX, ZCP_RUN_INFO_KEY);
+       VERIFY3U(3, ==, lua_gettop(state));
+
+       /*
+        * Tell the Lua interpreter to call our handler every count
+        * instructions. Channel programs that execute too many instructions
+        * should die with ETIME.
+        */
+       (void) lua_sethook(state, zcp_lua_counthook, LUA_MASKCOUNT,
+           zfs_lua_check_instrlimit_interval);
+
+       /*
+        * Tell the Lua memory allocator to stop using KM_SLEEP before handing
+        * off control to the channel program. Channel programs that use too
+        * much memory should die with ENOSPC.

Shouldn't it be ENOMEM? I think ENOSPC is mean for out-of *disk* space, not 
memory.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/397#pullrequestreview-43932909
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/Tffb276f83a8ecdd2-Ma087c0de506c8f2ef5fa9317
Powered by Topicbox: https://topicbox.com

Reply via email to