richardelling commented on this pull request.
> @@ -59,6 +59,11 @@ vdev_file_open(vdev_t *vd, uint64_t *psize, uint64_t
> *max_psize,
int error;
/*
+ * Rotational optimizations only make sense on block devices
nit: don't assume people have common sense. A better approach is:
Rotational optimizations only apply to block devices.
> @@ -59,6 +59,11 @@ vdev_file_open(vdev_t *vd, uint64_t *psize, uint64_t
> *max_psize,
int error;
/*
+ * Rotational optimizations only make sense on block devices
... which means that the real value should be "rotational" rather than
"non-rotational" thereby eliminating later confusion as new vdev types are
added.
Indeed, in Linux, the block device queue sysfs parameter is "rotational"
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/470#pullrequestreview-64632087
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T2365753bb8ec5214-M01ffb43af1047c447898c725
Powered by Topicbox: https://topicbox.com
