behlendorf commented on this pull request.


> @@ -59,6 +59,11 @@ vdev_file_open(vdev_t *vd, uint64_t *psize, uint64_t 
> *max_psize,
        int error;
 
        /*
+        * Rotational optimizations only make sense on block devices

So under Linux in user space this tuning does appear as 
`/sys/block/<blkdev>/queue/rotational`, sadly on the kernel side the helper 
function is called `blk_queue_nonrot()`.  Which is why this ended up being 
named `vdev_nonrot`. I wouldn't mind renaming it to `vdev_rotational`.


While it's true that this entry is called "rotational" when users see this 
parameter listed in 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/470#discussion_r140545011
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T2365753bb8ec5214-M48245bbf428b920e7f6145a6
Powered by Topicbox: https://topicbox.com

Reply via email to