richardelling commented on this pull request.
> @@ -59,6 +59,11 @@ vdev_file_open(vdev_t *vd, uint64_t *psize, uint64_t
> *max_psize,
int error;
/*
+ * Rotational optimizations only make sense on block devices
I don't think we need a code change here, there is lots of existing baggage to
deal with. For example, in illumos there are two flags in sd:
un_f_is_rotational and un_f_is_solid_state.
I'd be happier with the comments taking the perspective that rotation is the
exception that applies to block devices.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/470#discussion_r140586759
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T2365753bb8ec5214-M16fb4b23eac60ee4b53ac331
Powered by Topicbox: https://topicbox.com
