> On 1 Oct 2017, at 19:25, Igor Kozhukhov <[email protected]> wrote: > > Hi All, > > i’d like proposed try to update sys/typs.h by changes what are available in > FreeBSD for better portality: > > igor@z172:~/users/igor/dilos-illumos$ g diff > diff --git a/usr/src/uts/common/sys/types.h b/usr/src/uts/common/sys/types.h > index dcb2c86283..a2e37263b8 100644 > --- a/usr/src/uts/common/sys/types.h > +++ b/usr/src/uts/common/sys/types.h > @@ -58,6 +58,11 @@ > #include <sys/types32.h> > #endif > > +typedef uint8_t u_int8_t; /* unsigned integrals > (deprecated) */ > +typedef uint16_t u_int16_t; > +typedef uint32_t u_int32_t; > +typedef uint64_t u_int64_t; > + > #ifdef __cplusplus > extern "C" { > #endif > > > i have found several userland apps what are needs where changes and I > understand - they are deprocated, but it can helps and reduce additional > patches in userland apps with portability and builds based on illumos env. > > If you are agreed - i can file a bug for it. >
I have different kind of question — the u_* types inFreeBSD at least are deprecated and handled quite the same way as we do - when you step on it, fix it:) so the actual question is, how many cases (approximately) there are and perhaps it is just wiser to use the strategy to fix things at the point of origin. Note, I have done such fixing myself and helped to get it done for illumos. Depending on the volume of the work, it still may be reasonable to have those types defined, but in my opinion, the focus should be on real fixes in any case - even if we do have this (temporary and deprecated) list of typedefs. rgds, toomas ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T0cc9a914d001ea54-M6ec2017784f64f08d7502a76 Powered by Topicbox: https://topicbox.com
