richardelling commented on this pull request.
> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+ vd->vdev_ashift = MAX(zfs_ashift_override, vd->vdev_ashift);
it seems strange than an override really isn't an override, it is MAX() of the
override and something else
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#pullrequestreview-99123563
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-M36177da9ac3fd11b67cb841d
Powered by Topicbox: https://topicbox.com
