richardelling commented on this pull request.
> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+ vd->vdev_ashift = MAX(zfs_ashift_override, vd->vdev_ashift);
A better name is `zfs_ashift_min` which is a fine approach.
For the name `zfs_ashift_override` the expected code is something like:
`vd->vdev_ashift = zfs_ashift_override > 0 ? zfs_ashift_override :
vd->vdev_ashift;`
which is also a fine approach.
Basically, I'd like to see it become less ambiguous and more consistent with
other tunables.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#discussion_r173607794
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-Mb4537cdc078097099d823227
Delivery options: https://openzfs.topicbox.com/groups
