brad-lewis commented on this pull request.
> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+ vd->vdev_ashift = MAX(zfs_ashift_override, vd->vdev_ashift);
Does it seem strange to you because the default also serves as the minimum(and
you'd like a separate minimum field) or is it using the term override when it
is subject to restrictions (and you prefer something more like
zfs_ashift_hint)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/570#discussion_r172650085
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/Te17b61abfaa32615-M5c87dcb55592b93519ab3b1c
Delivery options: https://openzfs.topicbox.com/groups
