tsoome commented on this pull request.
> vdev_dbgmsg(vd, "vdev_disk_open: invalid "
"vdev_devid '%s'", vd->vdev_devid);
- return (SET_ERROR(EINVAL));
+ dvd->vd_devid = NULL;
+ dvd->vd_minor = NULL;
}
}
we also need this fix (wrong field is checked against NULL):
diff --git a/usr/src/uts/common/fs/zfs/vdev_disk.c
b/usr/src/uts/common/fs/zfs/vdev_disk.c
index 93b24fcaf1..1b6592344a 100644
--- a/usr/src/uts/common/fs/zfs/vdev_disk.c
+++ b/usr/src/uts/common/fs/zfs/vdev_disk.c
@@ -363,7 +363,7 @@ vdev_disk_open(vdev_t *vd, uint64_t *psize, uint64_t
*max_psize,
/*
* Compare the devid to the stored value.
*/
- if (error == 0 && vd->vdev_devid != NULL &&
+ if (error == 0 && vd->vd_devid != NULL &&
ldi_get_devid(dvd->vd_lh, &devid) == 0) {
if (ddi_devid_compare(devid, dvd->vd_devid) != 0) {
error = SET_ERROR(EINVAL);
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/605#pullrequestreview-114355261
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T33087f87f64e654e-M8e50944d9ae1c67108110c1a
Delivery options: https://openzfs.topicbox.com/groups
