pzakha requested changes on this pull request.
> vdev_dbgmsg(vd, "vdev_disk_open: invalid "
"vdev_devid '%s'", vd->vdev_devid);
- return (SET_ERROR(EINVAL));
+ dvd->vd_devid = NULL;
+ dvd->vd_minor = NULL;
}
}
There are other checks below that need to have the same modification:
https://github.com/openzfs/openzfs/pull/605/files#diff-9ab1cde67323e116c09c49bd9d6a343aR391
https://github.com/openzfs/openzfs/pull/605/files#diff-9ab1cde67323e116c09c49bd9d6a343aR403
> vdev_dbgmsg(vd, "vdev_disk_open: invalid "
"vdev_devid '%s'", vd->vdev_devid);
- return (SET_ERROR(EINVAL));
+ dvd->vd_devid = NULL;
+ dvd->vd_minor = NULL;
}
}
We've had some different issues with devids, where we wanted to bypass the
devid check as well. Setting `vd->vdev_devid` to NULL also works but has the
side effect of forever removing the devid from the config, which might not be
ideal in some cases. I'm guessing that with this code the original devid is
conserved in the config, even after successfully importing and exporting the
pool?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/605#pullrequestreview-128190752
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/T33087f87f64e654e-M53809d67e163a4a4a5f0ba25
Delivery options: https://openzfs.topicbox.com/groups
