Reviewed by: Sara Hartse <[email protected]>
Reviewed by: Sebastien Roy <[email protected]>
Reviewed by: Matthew Ahrens <[email protected]>
Reviewed by: George Wilson <[email protected]>
There are use-cases when we want to look into dataset performance
(reads/writes) in ZFS and create high-level tooling for it.
In illumos we already have some of these kstats already in the VFS
layer (module:unix - name:vopstats_<fs_id of dataset here>). That
said we want to introduce kstats specific to ZFS for the following
reasons:
[1] The current kstats don't support R/W to ZVOL's as these code
paths don't go through VFS.
[2] The VFS version of these statistics are not surrounded by locks
on purpose so performance of this hot paths doesn't take a hit.
That's generally fine but it also means that the values are not
fully accurate. In this new version of kstats we can take
advantage of the aggsum_t counters (already used for ARC related
kstats) which would take care of most of that overhead.
[3] Linux does not have the VFS kstats of illumos in its own VFS
layer, and they would have to implement this feature anyway. Thus
it would be nice to have the codebase being consistent among
variants.
Upstream Bugs: DLPX-58996, DLPX-59190
Closes XXX
You can view, comment on, or merge this pull request online at:
https://github.com/openzfs/openzfs/pull/664
-- Commit Summary --
* 9647 Introduce ZFS Read/Write kstats
-- File Changes --
M usr/src/common/zfs/zpool_prop.c (4)
M usr/src/man/man1m/zpool.1m (9)
M usr/src/uts/common/fs/zfs/spa.c (2)
M usr/src/uts/common/fs/zfs/sys/zfs_vfsops.h (23)
M usr/src/uts/common/fs/zfs/sys/zvol.h (7)
M usr/src/uts/common/fs/zfs/zfs_vfsops.c (158)
M usr/src/uts/common/fs/zfs/zfs_vnops.c (87)
M usr/src/uts/common/fs/zfs/zvol.c (215)
M usr/src/uts/common/io/comstar/lu/stmf_sbd/sbd_zvol.c (42)
M usr/src/uts/common/sys/fs/zfs.h (3)
-- Patch Links --
https://github.com/openzfs/openzfs/pull/664.patch
https://github.com/openzfs/openzfs/pull/664.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/664
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/Ta167a88bbab5c009-M3094716ab1dccb1b53c40b3b
Delivery options: https://openzfs.topicbox.com/groups
