Ramzec commented on this pull request.
> + * There should not be anything wrong with having kstats for + * snapshots. Since we are not sure how useful they would be + * though nor how much their memory overhead would matter in + * a filesystem with many snapshots, we skip them for now. + */ + if (zfsvfs->z_issnap) + return; + + /* + * We are limited by KSTAT_STRLEN for the kstat's name here + * which is a lot less that the string length of a dataset's + * path. Thus, we distinguish handles by their objset IDs + * prepended by the pool's load_guid. Note that both numbers + * are formatted in hex. See breakdown in comment below. + * + * We use the pool's load_guid because it is guaranteed to Do you mean that the pool-guid can be changed without re-import of the corresponding pool, that will require recreate of kstat-structures? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/664#pullrequestreview-135926959 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/Ta167a88bbab5c009-Mfcc83c377b1d5401ea1c9dfd Delivery options: https://openzfs.topicbox.com/groups
