On Fri, Apr 18, 2014 at 9:07 AM, Ira Cooper <[email protected]> wrote:

>
>
>
> On Fri, Apr 18, 2014 at 11:57 AM, Matthew Ahrens 
> <[email protected]>wrote:
>
>> On Thu, Apr 17, 2014 at 11:41 PM, Jim Klimov <[email protected]>wrote:
>>
>>>
>>> And on a side note, is there an easy way to know what source commits or
>>> bug fixes are present in the running (installed) kernel - perhaps, a git/mq
>>> history in a standardly provided text file or something like that? If not,
>>> would it make sense to add such a file to the build-product of illumos-gate?
>>>
>>>
>> I think it would be great to do something like this, and include it
>> kernel memory so it's part of the crash dump as well.
>>
>> As a practical suggestion, how about we take the first 1MB of "git log",
>> gzip it, and compile it into a kernel variable.  Then add a mdb dcmd to
>> ungzip and print it out.  I won't have time to implement this in the near
>> term; if others think this would be useful and have time, I'd be happy to
>> mentor / review.
>>
>>
>>
> git log --oneline - the actual commit text doesn't matter as much as which
> commits made it. :)
>

For illumos-formatted commit messages, "git log --oneline" includes the
entire actual commit text, just in a harder to read format (all lines
smushed into one).  I guess it leaves out the date and the author, both of
which are pretty useful.

Which would you rather read:

commit f7dbdfc7b241e42b135dc9118e41b127cb935483
Author: Marcel Telka <[email protected]>
Date:   Tue Jan 21 19:27:05 2014 +0100

    4512 kclient(1m) should not depend on /usr/xpg4/bin/grep
    Reviewed by: Andy Stormont <[email protected]>
    Reviewed by: Garrett D'Amore <[email protected]>
    Approved by: Robert Mustacchi <[email protected]>

commit 19d32b9ab53d17ac6605971e14c45a5281f8d9bb
Author: Robert Mustacchi <[email protected]>
Date:   Thu Dec 5 01:26:55 2013 +0000

    4493 want siginfo
    4494 Make dd show progress when you send INFO/USR1 signals
    4495 dd could support O_SYNC and O_DSYNC
    Reviewed by: Jerry Jelinek <[email protected]>
    Reviewed by: Joshua M. Clulow <[email protected]>
    Reviewed by: Richard Lowe <[email protected]>
    Reviewed by: Garrett D'Amore <[email protected]>
    Approved by: Garrett D'Amore <[email protected]>

---- or -----

f7dbdfc 4512 kclient(1m) should not depend on /usr/xpg4/bin/grep Reviewed
by: Andy Stormont <[email protected]> Reviewed by: Garrett D'Amore <
[email protected]> Approved by: Robert Mustacchi <[email protected]>
19d32b9 4493 want siginfo 4494 Make dd show progress when you send
INFO/USR1 signals 4495 dd could support O_SYNC and O_DSYNC Reviewed by:
Jerry Jelinek <[email protected]> Reviewed by: Joshua M. Clulow <
[email protected]> Reviewed by: Richard Lowe <[email protected]> Reviewed
by: Garrett D'Amore <[email protected]> Approved by: Garrett D'Amore <
[email protected]>

--matt
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to