On Fri, Apr 18, 2014 at 11:41 AM, Josef 'Jeff' Sipek <[email protected]>wrote:
> On Fri, Apr 18, 2014 at 11:31:56AM -0700, Matthew Ahrens wrote: > > On Fri, Apr 18, 2014 at 11:23 AM, Josef 'Jeff' Sipek < > [email protected]>wrote: > > > Why such a heavy-handed approach? Why not just stash the output from > > > `git describe --dirty --tags` into a const global and calling it > > > descriptive > > > enough? > > > > > > I'm not a git expert so I definitely appreciate suggestions as to what > data > > to include. Running that command on my workspace doesn't give me > anything > > that I recognize. From this how would you figure out if a given bug is > > fixed? > > > > $ git describe --dirty --tags > > codecomplete/4.0-207-g7774749 > > > > (Don't know what 4.0 is? I don't know the release scheme of every > illumos > > distro either.) > > Note the -gXXXXXX blob. Those are the first n chars of the git commit. > > Based on what you pasted, I know that the code you have checked out is: > > (1) 207 commits past codecomplete/4.0 > (2) the commit hash starts with '7774749' > > That combined with the knowledge of which repo the code came from (which > your scheme kinda requires too unless *every* fix you care about happens to > fit in the 1MB) points me to a specific revision. That's true. As far as I can tell, my proposal gives a superset of what anyone else has suggested, and I haven't seen any arguments why that is bad. I think it's better because I don't have to know all possible git repos. If I see that a given build has all the illumos commits from April 2012 - March 2014 (1MB worth), I can reasonably guess that it has all the commits from before that too. But you do have a point, so I'll modify my suggestion: just include the entire "git log", gzipped, in the running kernel. It's only 1.5MB. All that said, I suppose the tie goes to whoever actually implements something like this. --matt
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
