On Fri, Apr 18, 2014 at 11:31:56AM -0700, Matthew Ahrens wrote: > On Fri, Apr 18, 2014 at 11:23 AM, Josef 'Jeff' Sipek > <[email protected]>wrote: > > Why such a heavy-handed approach? Why not just stash the output from > > `git describe --dirty --tags` into a const global and calling it > > descriptive > > enough? > > > I'm not a git expert so I definitely appreciate suggestions as to what data > to include. Running that command on my workspace doesn't give me anything > that I recognize. From this how would you figure out if a given bug is > fixed? > > $ git describe --dirty --tags > codecomplete/4.0-207-g7774749 > > (Don't know what 4.0 is? I don't know the release scheme of every illumos > distro either.)
Note the -gXXXXXX blob. Those are the first n chars of the git commit. Based on what you pasted, I know that the code you have checked out is: (1) 207 commits past codecomplete/4.0 (2) the commit hash starts with '7774749' That combined with the knowledge of which repo the code came from (which your scheme kinda requires too unless *every* fix you care about happens to fit in the 1MB) points me to a specific revision. For example given 20140320-15-g83e627e from Joyent's SmartOS repo: jeffpc@meili:~/illumos/illumos-joyent$ git show 20140320-15-g83e627e commit 83e627e6cb26a200b4fce0b7aad1480202411103 Merge: 89b7e5b dff8ce8 Author: Keith M Wesolowski <[email protected]> Date: Mon Mar 24 21:02:12 2014 +0000 [illumos-gate merge] commit dff8ce8858f30b8b43711766bd0f637548b8d700 3379 Duplicate assignment in uts/common/cpr/cpr_stat.c commit 652fb50dec8e8b074b60a3c82d00248a2aeb5eb9 4653 net hooks registered with HH_BEFORE or HH_AFTER hints create invalid hint_value kstats commit 4948216cdd0ccee7b9a4fd433ccab571afbb99e9 4679 want workaround for Intel erratum BT81 commit 56b8f71e3a910fbd2820f6841b40bfd85f9673c2 4601 memory leak in ILB daemon on startup 4602 memory leak in ILB daemon on import-config 4668 Memory leak in ilbd' new_req: getpeerucred() allocation isn't released at all commit 61f9f3e6dc0a66ec5c243562765c1b4a3297e8a4 4688 getlogin_r shouldn't clobber memory Jeff. -- Once you have their hardware. Never give it back. (The First Rule of Hardware Acquisition) _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
