> On April 6, 2015, 2:28 p.m., Bayard Bell wrote: > > usr/src/lib/libzfs/common/libzfs_dataset.c, line 1571 > > <https://reviews.csiden.org/r/181/diff/1/?file=14418#file14418line1571> > > > > Nit: "to perform postfix on later" is a little clumsy when "for > > postfix" will do.
fixed > On April 6, 2015, 2:28 p.m., Bayard Bell wrote: > > usr/src/lib/libzfs/common/libzfs_dataset.c, line 1574 > > <https://reviews.csiden.org/r/181/diff/1/?file=14418#file14418line1574> > > > > This might read better as a while loop, initializing elem to NULL in > > the preceding line. this is actually the canonical way of iterating an nvlist. IMO it's better than a while loop because the iteration logic and variable are contained within the "for" statement. > On April 6, 2015, 2:28 p.m., Bayard Bell wrote: > > usr/src/lib/libzfs/common/libzfs_dataset.c, line 1665 > > <https://reviews.csiden.org/r/181/diff/1/?file=14418#file14418line1665> > > > > In case of error, do we want to return the result of the last > > operation, the result of the first error result, or the number of times we > > errored? Currently we do the first, and I'm not sure that's what we want. In the absence of additional infrastructure to return all of the errors, I'm fine with returning "one of the errors that occurred". - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/181/#review613 ----------------------------------------------------------- On April 6, 2015, 1:06 a.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/181/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 1:06 a.m.) > > > Review request for OpenZFS Developer Mailing List, Christopher Siden and > Chris Williamson. > > > Bugs: 5745 > https://www.illumos.org/projects/illumos-gate//issues/5745 > > > Repository: illumos-gate > > > Description > ------- > > 5745 zfs set allows only one dataset property to be set at a time > Reviewed by: Christopher Siden <[email protected]\> > Reviewed by: George Wilson <[email protected]\> > Reviewed by: Matthew Ahrens <[email protected]\> > > Original author: Chris Williamson > > > Diffs > ----- > > usr/src/man/man1m/zfs.1m 2aa37cfdbeaef883a5a7736a42f99fc45768b4ae > usr/src/lib/libzfs/common/libzfs_util.c > 414d74ee20660a067cf224b91677c09658a05854 > usr/src/lib/libzfs/common/libzfs.h 9aa5ba59056455d7ecc510189546a1349d65eaa5 > usr/src/cmd/zfs/zfs_main.c 5037325e9bcdb543cd16b733e4ff2137a6b37b72 > usr/src/lib/libzfs/common/mapfile-vers > 65f266996e168c55d600e26895a12e0ab4cad460 > usr/src/lib/libzfs/common/libzfs_dataset.c > 05a2fdc9bec02b91a1cd48b1bf81ac581f726e28 > > Diff: https://reviews.csiden.org/r/181/diff/ > > > Testing > ------- > > ztest > zfs test suite > manual testing of new feature > > http://jenkins/job/zfs-precommit/1910/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
