> On April 6, 2015, 2:28 p.m., Bayard Bell wrote: > > usr/src/lib/libzfs/common/libzfs_dataset.c, line 1665 > > <https://reviews.csiden.org/r/181/diff/1/?file=14418#file14418line1665> > > > > In case of error, do we want to return the result of the last > > operation, the result of the first error result, or the number of times we > > errored? Currently we do the first, and I'm not sure that's what we want. > > Matthew Ahrens wrote: > In the absence of additional infrastructure to return all of the errors, > I'm fine with returning "one of the errors that occurred". > > Bayard Bell wrote: > Right, but we simply assign to ret every time, which means we return the > last result, which means we could drop a non-zero result?
Ah, good point. I missed that. Will change to return the last non-zero error! - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/181/#review613 ----------------------------------------------------------- On April 6, 2015, 6:37 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/181/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 6:37 p.m.) > > > Review request for OpenZFS Developer Mailing List, Christopher Siden and > Chris Williamson. > > > Bugs: 5745 > https://www.illumos.org/projects/illumos-gate//issues/5745 > > > Repository: illumos-gate > > > Description > ------- > > 5745 zfs set allows only one dataset property to be set at a time > Reviewed by: Christopher Siden <[email protected]\> > Reviewed by: George Wilson <[email protected]\> > Reviewed by: Matthew Ahrens <[email protected]\> > > Original author: Chris Williamson > > > Diffs > ----- > > usr/src/man/man1m/zfs.1m 2aa37cfdbeaef883a5a7736a42f99fc45768b4ae > usr/src/lib/libzfs/common/mapfile-vers > a911b73d947269afdf55d170be638b6dee06dfe8 > usr/src/lib/libzfs/common/libzfs_util.c > 1adea255b482b955f68d64d33fc0a06564d4e766 > usr/src/lib/libzfs/common/libzfs_dataset.c > 05a2fdc9bec02b91a1cd48b1bf81ac581f726e28 > usr/src/lib/libzfs/common/libzfs.h d1c9e005478e665fb830bf3e724cd381229fb731 > usr/src/cmd/zfs/zfs_main.c 5037325e9bcdb543cd16b733e4ff2137a6b37b72 > > Diff: https://reviews.csiden.org/r/181/diff/ > > > Testing > ------- > > ztest > zfs test suite > manual testing of new feature > > http://jenkins/job/zfs-precommit/1910/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
