> On April 6, 2015, 3 p.m., Steven Hartland wrote: > > usr/src/cmd/zfs/zfs_main.c, line 608 > > <https://reviews.csiden.org/r/181/diff/2/?file=14841#file14841line608> > > > > Not related to this change but as parseprop returns an int not a bool > > it be more correct to check its return with != 0 while your there, which > > could prevent compiler warnings moving forward.
fixed. > On April 6, 2015, 3 p.m., Steven Hartland wrote: > > usr/src/lib/libzfs/common/libzfs_dataset.c, line 1596 > > <https://reviews.csiden.org/r/181/diff/2/?file=14843#file14843line1596> > > > > Is this needed given the use of calloc, so its already initialised to > > zero? it's not needed, removed. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/181/#review614 ----------------------------------------------------------- On April 6, 2015, 1:06 a.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/181/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 1:06 a.m.) > > > Review request for OpenZFS Developer Mailing List, Christopher Siden and > Chris Williamson. > > > Bugs: 5745 > https://www.illumos.org/projects/illumos-gate//issues/5745 > > > Repository: illumos-gate > > > Description > ------- > > 5745 zfs set allows only one dataset property to be set at a time > Reviewed by: Christopher Siden <[email protected]\> > Reviewed by: George Wilson <[email protected]\> > Reviewed by: Matthew Ahrens <[email protected]\> > > Original author: Chris Williamson > > > Diffs > ----- > > usr/src/man/man1m/zfs.1m 2aa37cfdbeaef883a5a7736a42f99fc45768b4ae > usr/src/lib/libzfs/common/libzfs_util.c > 414d74ee20660a067cf224b91677c09658a05854 > usr/src/lib/libzfs/common/libzfs.h 9aa5ba59056455d7ecc510189546a1349d65eaa5 > usr/src/cmd/zfs/zfs_main.c 5037325e9bcdb543cd16b733e4ff2137a6b37b72 > usr/src/lib/libzfs/common/mapfile-vers > 65f266996e168c55d600e26895a12e0ab4cad460 > usr/src/lib/libzfs/common/libzfs_dataset.c > 05a2fdc9bec02b91a1cd48b1bf81ac581f726e28 > > Diff: https://reviews.csiden.org/r/181/diff/ > > > Testing > ------- > > ztest > zfs test suite > manual testing of new feature > > http://jenkins/job/zfs-precommit/1910/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
