----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/256/#review825 -----------------------------------------------------------
you also need to modify the mapfile usr/src/lib/libzfs_core/common/libzfs_core.c (lines 547 - 550) <https://reviews.csiden.org/r/256/#comment620> we should document that the begin record must not be byteswapped (i.e. it should be the same as what's in the stream). It's mentioned in a comment buried in the func, but would be good to document it here too. usr/src/lib/libzfs_core/common/libzfs_core.c (lines 557 - 559) <https://reviews.csiden.org/r/256/#comment621> Are you sure that we want to change the API, vs. adding a new function with the new signature? We haven't committed to the lzc interface yet so we still can change it, but it seems "nice" to retain compatability where it isn't too gross. e.g. add a new func like "lzc_receive2" or "lzc_receive_record" that takes the begin_record, and leave the old lzc_receive with the same interface. - Matthew Ahrens On Oct. 9, 2015, 8:55 a.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/256/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 8:55 a.m.) > > > Review request for OpenZFS Developer Mailing List and Matthew Ahrens. > > > Bugs: 6051 > https://www.illumos.org/issues/6051 > > > Repository: illumos-gate > > > Description > ------- > > The begin record contains useful information that the caller might > want to have the access to, so that it can be used to derive values > for 'snapname' and 'origin' parameters. > > New lzc_receive_basic function is added as a replacement for the > previous lzc_receive in the simpler situations. > > > Diffs > ----- > > usr/src/lib/libzfs_core/common/libzfs_core.c > 22af0f4a7a9fd8ab15cc7880233ba51274ce87d8 > usr/src/lib/libzfs_core/common/libzfs_core.h > bdd6c951ee496dc1e21a297e7a69b1342aecf79b > > Diff: https://reviews.csiden.org/r/256/diff/ > > > Testing > ------- > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
