> On Oct. 24, 2015, 8:23 a.m., Matthew Ahrens wrote: > > Changes look good. FYI, you will need to explain what testing you did when > > filing the RTI. At a minimum, run the test suite on illumos to exercise > > the changes to the pre-existing funcs. (or open a pull request against > > https://github.com/openzfs/openzfs and we will do the regression tests and > > RTI for you)
Matt, thanks! I will do one of those things. The change has also been verified by the test cases included with https://github.com/ClusterHQ/pyzfs. BTW, could you please updated sysnopsis of the connected issue? It actually describes the previous suggested solution rather than the problem that we are trying to solve. - Andriy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/256/#review851 ----------------------------------------------------------- On Oct. 30, 2015, 12:54 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/256/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 12:54 p.m.) > > > Review request for OpenZFS Developer Mailing List and Matthew Ahrens. > > > Bugs: 6051 > https://www.illumos.org/issues/6051 > > > Repository: illumos-gate > > > Description > ------- > > The begin record contains useful information that the caller might > want to have the access to, so that it can be used to derive values > for 'snapname' and 'origin' parameters. > > New lzc_receive_basic function is added as a replacement for the > previous lzc_receive in the simpler situations. > > > Diffs > ----- > > usr/src/lib/libzfs_core/common/mapfile-vers > acd4efb07e8b97c093a7380281c96dc589f472c1 > usr/src/lib/libzfs_core/common/libzfs_core.c > d66f338a78baccaf8675f160b57fb93cb937a7ca > usr/src/lib/libzfs_core/common/libzfs_core.h > 5d3a6fda7dcb9f96801d7f23647f410eb51f45bf > > Diff: https://reviews.csiden.org/r/256/diff/ > > > Testing > ------- > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
