> On Oct. 9, 2015, 9:27 p.m., Matthew Ahrens wrote: > > usr/src/lib/libzfs_core/common/libzfs_core.c, lines 557-559 > > <https://reviews.csiden.org/r/256/diff/1/?file=17800#file17800line557> > > > > Are you sure that we want to change the API, vs. adding a new function > > with the new signature? We haven't committed to the lzc interface yet so > > we still can change it, but it seems "nice" to retain compatability where > > it isn't too gross. > > > > e.g. add a new func like "lzc_receive2" or "lzc_receive_record" that > > takes the begin_record, and leave the old lzc_receive with the same > > interface. > > Andriy Gapon wrote: > I probably misunderstood an earlier suggestion of yours. Indeed, I do > not see any good reason to break the backward compatibility. > I'll spend a little more time looking for a better name for the new > function. `lzc_receive2` is pretty non-descriptive. `lzc_receive_record` is > better, but still could be misinterpreted as "receive a (single) record". To > be honest I do not have anything better on my mind right now, but *[having > just read [this](http://ozlabs.org/~rusty/index.cgi/tech/2008-03-30.html)]* I > hope that there is a name that would make the purpose of the new function > clear enough even without looking at its documentation or even implementation.
Agreed that naming is hard. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/256/#review825 ----------------------------------------------------------- On Oct. 9, 2015, 8:55 a.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/256/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 8:55 a.m.) > > > Review request for OpenZFS Developer Mailing List and Matthew Ahrens. > > > Bugs: 6051 > https://www.illumos.org/issues/6051 > > > Repository: illumos-gate > > > Description > ------- > > The begin record contains useful information that the caller might > want to have the access to, so that it can be used to derive values > for 'snapname' and 'origin' parameters. > > New lzc_receive_basic function is added as a replacement for the > previous lzc_receive in the simpler situations. > > > Diffs > ----- > > usr/src/lib/libzfs_core/common/libzfs_core.c > 22af0f4a7a9fd8ab15cc7880233ba51274ce87d8 > usr/src/lib/libzfs_core/common/libzfs_core.h > bdd6c951ee496dc1e21a297e7a69b1342aecf79b > > Diff: https://reviews.csiden.org/r/256/diff/ > > > Testing > ------- > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
