On Jan 12, 2004, at 11:09 AM, Pierre van Rooden wrote:
Daniel Ockeloen wrote:a) change a depr. call in MMBase.java : getSendMail() to return null and print a clear error in the log explaining how to solve it (you should use getModule anyway).
Note that if you change it you will also need to change the return type.
Since this will break code that calls this method anyway, it may be better to simply remove it, instead of changing it now and removing it in 1.8.
I like that better too but the result would be a Method not found without any info in the log, by (indeed) changing the return type and letting it do
a log.info and log.error the user would atleast be pointed to what happend. I see this as a 'second' level of deprecated (hehe) since the call was
all ready assigned to be removed in 1.8. But if others agree (head of cleanup project?) i would be more than happy to remove it.
b) turn sendmail.xml module default to 'inactive' with comments in this file on the 2 new options you can use (it will include a commnent : look to the readme of the new email app).
Why not include the main content of the readme?
Wel thats a docbook ?
[X] +1 (YEA)
In favor but see my suggestions above.
Noted i guess the 100% remove or my 'keep for a warning' is upto the cleanup project leader.
Daniel.
