On Fri, Jan 25, 2013 at 12:15:33PM +0100, Simon Hausmann wrote:
> Ossi, does it make more sense if the skill we are talking about here
> is the ability to tell whether a change in their area of expertise is
> correct or not, with a probability of correctness high enough to bring
> the project forward?
> 
> Isn't that the skill that an approver has over a regular contributor?
> 
of course it is. but it is not the only skill. a contribution may be
technically as correct as it gets, but if the contributor lives in his
tiny world without ever having looked outside, there is a good chance he
will miss some of the more subtle aspects of doing a proper review.
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to