On sexta-feira, 25 de janeiro de 2013 14.10.56, Oswald Buddenhagen wrote: > of course it is. but it is not the only skill. a contribution may be > technically as correct as it gets, but if the contributor lives in his > tiny world without ever having looked outside, there is a good chance he > will miss some of the more subtle aspects of doing a proper review.
You're completely right on that one. But I think that the approvers nominating and seconding use their grey matter to decide whether the new proposed approver would do a correct review. Besides, I don't think there's anything wrong in giving approver rights for someone who has no clue about most of Qt. I can't claim that myself! I know QtCore, QtNetwork and QtDBus. I will refrain from approving elsewhere. Why can't new approvers do the same? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
