On domingo, 24 de fevereiro de 2013 09.34.43, Thiago Macieira wrote: > However, I can't be sure because the diff between the two branches is > unreviewable, since every header is modified. Someone needs to produce a > clean diff we can review and post to the list.
Tuukka told me in an email probably mistakenly sent privately only that I could compare 4.7.4 and 4.7.5. I was waiting for the email to show up on the ML before I would reply. It backports 98d51e42c81c0674bc724eccbdf8521d9317998a to make QtConcurrent support handling exceptions. That's two mistakes in one: first, it's a new feature in a patch release. Second, it misses backporting 451c3e973a49c8b467cc865f6d1f4a2c21902dc7, which removed a stray qDebug that was printed whenever an exception was caught. The backport of 8afc6773067bb878020c29b3bebfe8662e3fbfdd (as 2fd21f04d23d5dd87ca0f6db238ae268492f5528) to add support for signed char as a metatype is dubious. It's a behaviour change, but it might be one that's acceptable in a patch release to fix a bug. Olivier, can you give me your opinion? The change is yours. The rest of the changes to QtCore and QtDBus do not seem harmful, though. There are certainly a few that I find questionable, like backporting changes to the Symbian codepaths. As for a full public header review, I have found something that shouldn't be there. bed275599ff44809372af99b9b6cbe492f5fdec8, an improperly-marked backport of 83ad5ebb033799352723a9d968b31a9cef61396c, adds a new public symbol. That change de-inlines a function in a public header, to the effect of breaking the forwards- and backwards-compatibility requirement of a patch release, despite what its changes file says. What do we do now? 1) Disavow that release, claiming it was never official and revert the change to 4.7.6? Anyone who compiled code with 4.7.5 will need to recompile. 2) Acknowledge the mistake, keep it for 4.7.6 and just add a note to the changes file? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
