> On 08 Apr 2015, at 13:13, Marc Mutz <[email protected]> wrote: > > Hi, > > I have in the past fixed #include mistakes such as #include > <qsharedpointer.h> > for QSharedDataPointer, and even though each time the issue came up that this > is a SiC change (but only for users that unduly rely on indirect includes), > so > far they were always accepted. > > When splitting off qHash() from qhash.h into qhashfunctions.h, I have come > across many files that included qhash.h without using it, and likewise some > for which qhashfunctions.h would suffice. One of them now got a -1 for being > SiC. > > Can we please decide once and for all whether #include cleanups that are > technically SiC are ok or not, if they only affect users that rely on > indirect > includes? > > My vote obviously goes to allowing them.
I had to fix includes when building client code with 5.5 branch (coming from 5.4.1), so this is an actual issue right now, not just a theoretical one. I can do more research which headers I needed to include, if that’s a help to anyone. -- Frank Osterfeld | [email protected] | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
