On Thursday 02 July 2009 23:31:56 Matthew Toseland wrote:
> A few notes on the commit:
>
> + } catch (MalformedURLException e) {
> + Logger.error(this, "Malformed URI in N2NTM Bookmark
> Feed message");
> + } catch (IllegalBase64Exception e) {
>
> - should return
>
> + description = encodedDescription == null ? null : new
> String(Base64.decode(encodedDescription));
>
> - why new String() ?
>
>
> Subscribe/UnsubscribeFeed etc etc should eventually be documented on the wiki.
>
>
>
> BookmarkFeedUserAlert: getTitle(), getText(), getShortText(), getHTMLText(),
> all need l10n. Likewise DownloadFeedUserAlert.
>
> UserAlertManager.register: do they need to run all in parallel? can't we push
> the loop to a single job?
>
> getAtom(): don't you want to include the # anchor to point to the specific
> message?
>
> Apart from the above, looks good...
>
In a later commit, in Send*FeedMessage:
protected int handleFeed(DarknetPeerNode pn) {
- return pn.sendBookmarkFeed(uri, name, description,
hasAnAnActiveLink);
+ return pn.sendBookmarkFeed(uri, name, new String(description),
hasAnAnActiveLink);
}
UTF-8??
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
