On Thursday 02 July 2009 23:31:56 Matthew Toseland wrote:
> A few notes on the commit:
>
> + } catch (MalformedURLException e) {
> + Logger.error(this, "Malformed URI in N2NTM Bookmark
> Feed message");
> + } catch (IllegalBase64Exception e) {
>
> - should return
>
> + description = encodedDescription == null ? null : new
> String(Base64.decode(encodedDescription));
>
> - why new String() ?
>
>
> Subscribe/UnsubscribeFeed etc etc should eventually be documented on the wiki.
>
>
>
> BookmarkFeedUserAlert: getTitle(), getText(), getShortText(), getHTMLText(),
> all need l10n. Likewise DownloadFeedUserAlert.
>
> UserAlertManager.register: do they need to run all in parallel? can't we push
> the loop to a single job?
>
> getAtom(): don't you want to include the # anchor to point to the specific
> message?
>
> Apart from the above, looks good...
>
An architectural issue:
Some user-alerts get updated frequently, is this a problem for the whole feed
subscriptions model? Do we want to send updated alerts to the FCP subscribers?
An example (not yet implemented) is that we will probably use a single alert to
tell the user that they have 5 new messages, rather than showing an alert for
each message; same with downloads.Really this suggests that maybe we want to separate events from alerts? Alerts are a list of problems or notices that are valid _now_, events are discrete moments in time? Perhaps an event is simply a new alert or a change to an alert, but really we want the event to describe _what has changed_ (file X downloaded), not the new status of the alert (6 files downloaded, rather than 5). Thoughts??
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Devl mailing list [email protected] http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
