Gianni Johansson schrieb: [mainport.params.servlet.7.params.sfDoParanoidChecks=false]
> This is not a good idea. Leave it on. I routinely see corrupted blocks. Do they have metadata? If thwy don't, it should help to declare all corrupted blocks with metadata as non-corrupted. > If > we catch them they can be retried or at least ignored. If you turn off > checking then in the best case the corrupted data will be used to reconstruct > the file and will be caught by the new checksuming code at the very end of > the download.. Getting corrupted data with no warning is nothing new on Freenet. So I'd only use files that have their own checksum (e. g. Zip files) > For old SplitFiles there is no checksum, and the user will > get corrupted data with no warning. is that checksum generated by the FEC code or does the client have to create it himself? So that will be the next thing that will delay next FIW version if I have to add code for that. > Why not just add a "Skip block checks" option to the UI which is off by > default and can be enabled by the user to get bad files? Another idea. Or switching it on automatically, if you have as many failures that you cannot complete the file and no successful block. > If anyone out there wants to go after the root problem of *why* we are > getting corrupted blocks, here's your chance to be a Freenet hero. ;-) it's caused by the datastore bug. As it cannot live in datastores any longer, it lives in splitfiles now. > I understand mihi is frustrated, but the idea of trying to support splitfiles > with metadata is just wrong. There is no reason to do it. Okay, you have the list of sites in my previous post. Download all splitfiles of them and reinsert them properly with at least HTL 20 onto your site. (that will also help the original authors, as they get KeyCollisions for the blocks when FIW is fixed.) When you are finished, come again and say "no reason" again. > It is hard and it complicates the code. ignoring it and swithcing all specialties off should not be the problem. Simply show a warning in the UI then... > Why doesn't someone just fix his code? I'll fix it, but not that week, not next week and most probably not the week after. And fixing the code does not help for the freesites that are already inserted. mihi _______________________________________________ devl mailing list devl at freenetproject.org http://hawk.freenetproject.org:8080/cgi-bin/mailman/listinfo/devl
