More comments below. What Ian told me was we should localise stuff that a
normal user will see i.e. only stuff that you don't have to turn on advanced
mode for. That was specifically regarding me doing the work though, it *may*
make sense to localise other stuff if we have the manpower.
On Saturday 27 October 2007 20:58, you wrote:
> Author: bombe
> Date: 2007-10-27 19:58:05 +0000 (Sat, 27 Oct 2007)
> New Revision: 15616
>
> Modified:
> trunk/freenet/src/freenet/clients/http/ConfigToadlet.java
> trunk/freenet/src/freenet/clients/http/ConnectionsToadlet.java
> trunk/freenet/src/freenet/clients/http/PproxyToadlet.java
> trunk/freenet/src/freenet/clients/http/QueueToadlet.java
> trunk/freenet/src/freenet/clients/http/StatisticsToadlet.java
> trunk/freenet/src/freenet/l10n/freenet.l10n.en.properties
> Log:
> fix issue #1824: add lots of l10n keys
>
> Modified: trunk/freenet/src/freenet/clients/http/ConfigToadlet.java
> ===================================================================
> --- trunk/freenet/src/freenet/clients/http/ConfigToadlet.java 2007-10-27
19:25:49 UTC (rev 15615)
> +++ trunk/freenet/src/freenet/clients/http/ConfigToadlet.java 2007-10-27
19:58:05 UTC (rev 15616)
> @@ -52,7 +52,7 @@
> }
>
> if(!ctx.isAllowedFullAccess()) {
> - super.sendErrorPage(ctx, 403, "Unauthorized",
L10n.getString("Toadlet.unauthorized"));
> + super.sendErrorPage(ctx, 403,
L10n.getString("Toadlet.unauthorizedTitle"),
L10n.getString("Toadlet.unauthorized"));
> return;
> }
>
> @@ -117,7 +117,7 @@
> public void handleGet(URI uri, HTTPRequest req, ToadletContext ctx)
> throws
ToadletContextClosedException, IOException {
>
> if(!ctx.isAllowedFullAccess()) {
> - super.sendErrorPage(ctx, 403, "Unauthorized",
L10n.getString("Toadlet.unauthorized"));
> + super.sendErrorPage(ctx, 403,
> L10n.getString("Unauthorized"),
L10n.getString("Toadlet.unauthorized"));
IIRC they are case sensitive. Also shouldn't this be the same as the previous
one? (Toadlet.unauthorizedTitle) ?
> return;
> }
>
> @@ -139,7 +139,7 @@
> HTMLNode nextTableCell = navigationTableRow;
>
> for(int i=0; i<sc.length;i++){
> -
nextTableCell.addChild("td", "class",
"config_navigation").addChild("li").addChild("a", "href", '#'
+sc[i].getPrefix(), sc[i].getPrefix());
> +
nextTableCell.addChild("td", "class",
"config_navigation").addChild("li").addChild("a", "href", '#'
+sc[i].getPrefix(), l10n(sc[i].getPrefix()));
Be consistent: if you're going to change the anchor IDs, also change the links
to them.
> }
> contentNode.addChild(navigationBar);
> }
> @@ -183,7 +183,7 @@
>
> if(displayedConfigElements>0) {
> formNode.addChild("div", "class",
> "configprefix", sc[i].getPrefix());
> - formNode.addChild("a", "id", sc[i].getPrefix());
> + formNode.addChild("a", "id",
> l10n(sc[i].getPrefix()));
> formNode.addChild(configGroupUlNode);
> }
> }
> @@ -216,12 +216,12 @@
>
> if(value) {
> result.addChild("option", new String[] { "value",
> "selected" }, new
String[] {
> - "true", "selected" }, "true");
> - result.addChild("option", "value", "false", "false");
> + "true", "selected" }, l10n("true"));
> + result.addChild("option", "value", "false",
> l10n("false"));
> } else {
> - result.addChild("option", "value", "true", "true");
> + result.addChild("option", "value", "true",
> l10n("true"));
> result.addChild("option", new String[] { "value",
> "selected" }, new
String[] {
> - "false", "selected" }, "false");
> + "false", "selected" }, l10n("false"));
This should work, but be careful of any case where we actually check the value
(there shouldn't be any...).
...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20071027/63da5d35/attachment.pgp>
