Let 20 members to compete for the same port definitely is a wrong idea. So I fixed this part by put back the random port (as first try)
However, to skip timeout part is great. I apply this changes and added test. I have worked out a new Pull-Request. On Wed, Sep 5, 2018 at 5:18 PM, Ryan McMahon <[email protected]> wrote: > Hi Gester, > > I had an idea for another approach which keeps the simplicity of @smgoller > <https://github.com/smgoller>'s original fix but addresses the hanging > during the 2 minute retry in AcceptorImpl. We can simply just bypass the 2 > minute retry logic if the CacheServerImpl is a GatewayReceiverImpl. There > is already a flag for this passed into the AcceptorImpl constructor. Check > out my branch: > > https://github.com/mcmellawatt/geode/tree/feature/GEODE-5591 > > It is possible that if say 20 gateway receivers are being created at the > same time that we will get 19 IOExceptions (they are all fighting for the > same port), but they will fail fast and move onto the next port in the > range. I don't think this would impact the user experience at all, just > something to keep in mind. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/geode/pull/2425#issuecomment-418922324>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AKN7Xtp3TUTyD53O4Xd-F6E-0Z9oxzPDks5uYGnugaJpZM4WbzYa> > . > [ Full content available at: https://github.com/apache/geode/pull/2425 ] This message was relayed via gitbox.apache.org for [email protected]
