Yes, I worked out a new diff to revoke this part of fix. On Thu, Sep 6, 2018 at 9:52 AM, Ryan McMahon <[email protected]> wrote:
> *@mcmellawatt* requested changes on this pull request. > > After a closer look, I think we should not bypass the retry logic for > gateway receivers. See my comment above. > ------------------------------ > > In geode-core/src/main/java/org/apache/geode/internal/cache/ > tier/sockets/AcceptorImpl.java > <https://github.com/apache/geode/pull/2425#discussion_r215698529>: > > > @@ -458,7 +458,8 @@ public AcceptorImpl(int port, String bindHostName, > > boolean notifyBySubscription, > this.serverSock.bind(new InetSocketAddress(getBindAddress(), > port), backLog); > break; > } catch (SocketException b) { > - if (!treatAsBindException(b) || System.currentTimeMillis() > > tilt) { > + if (isGatewayReceiver || !treatAsBindException(b) > > See my other comment - I think that this retry logic is protecting us > against a specific case when the server restarts and encounters a bind > exception, so it is probably wise to leave this file how it was. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/geode/pull/2425#pullrequestreview-153022519>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AKN7XhUnBeAthfDGnZU-svzueTzfZiAdks5uYVLcgaJpZM4WbzYa> > . > [ Full content available at: https://github.com/apache/geode/pull/2425 ] This message was relayed via gitbox.apache.org for [email protected]
