First commit! Yeah :) Champagne!

Some questions below (hey I couldn't left the first commit go without questions 
;))

On Jan 21, 2010, at 4:24 PM, evalica (SVN) wrote:

> Author: evalica
> Date: 2010-01-21 16:24:22 +0100 (Thu, 21 Jan 2010)
> New Revision: 26284
> 
> Modified:
>   platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css
> Log:
> XSCOLIBRI-180: Scroll and width problems on Stats space
> 
> Modified: platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css
> ===================================================================
> --- platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css       
> 2010-01-21 14:52:45 UTC (rev 26283)
> +++ platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css       
> 2010-01-21 15:24:22 UTC (rev 26284)
> @@ -1316,7 +1316,7 @@
> }
> 
> div.panellayoutcontainer-2col .panellayoutcol {
> -  width: 50%;
> +  width: 49%;

Where does this magic number come from? Is the 1% important? If so maybe this 
warrants some comment?

> }
> 
> div.panellayoutcontainer-3col .panellayoutcol {
> @@ -1324,11 +1324,11 @@
> }
> 
> div.panellayoutcontainer-4col .panellayoutcol {
> -  width: 25%;
> +  width: 24%;

same

> }
> 
> div.panellayoutcontainer-5col .panellayoutcol {
> -  width: 20%;
> +  width: 19%;

same

> }
> 
> div.panellayoutcontainer-1col, div.panellayoutcontainer-2col, 
> div.panellayoutcontainer-3col, div.panellayoutcontainer-4col, 
> div.panellayoutcontainer-5col {
> @@ -1339,15 +1339,13 @@
> .panellayoutcol {
>   float: left;
>   height: 1%;
> -  overflow: auto;
> -
> }
> 
> .panellayoutcol .panel {
> -  border: 1px solid #ddd;
> -  margin: 0 0 20px 5%;
> +  border: 1px solid $theme.borderColor;
> +  margin: 0 0 5% 5%;
> +  overflow-x: auto;
>   width: 90%;
> -
> }
> 
> #xwikicontent .panel ul {

Thanks
-Vincent

_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to