On Jan 21, 2010, at 4:50 PM, Sergiu Dumitriu wrote:
> On 01/21/2010 04:32 PM, Vincent Massol wrote:
>> First commit! Yeah :) Champagne!
>>
>> Some questions below (hey I couldn't left the first commit go without
>> questions ;))
>>
>> On Jan 21, 2010, at 4:24 PM, evalica (SVN) wrote:
>>
>>> Author: evalica
>>> Date: 2010-01-21 16:24:22 +0100 (Thu, 21 Jan 2010)
>>> New Revision: 26284
>>>
>>> Modified:
>>> platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css
>>> Log:
>>> XSCOLIBRI-180: Scroll and width problems on Stats space
>>>
>>> Modified:
>>> platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css
>>> ===================================================================
>>> --- platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css
>>> 2010-01-21 14:52:45 UTC (rev 26283)
>>> +++ platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css
>>> 2010-01-21 15:24:22 UTC (rev 26284)
>>> @@ -1316,7 +1316,7 @@
>>> }
>>>
>>> div.panellayoutcontainer-2col .panellayoutcol {
>>> - width: 50%;
>>> + width: 49%;
>>
>> Where does this magic number come from? Is the 1% important? If so maybe
>> this warrants some comment?
>
> There are rounding errors in IE, sometimes 50% + 50% = 101%
ok thanks. My question was more: shouldn't we comment it?
Or is it more generic and in this case should it be decided as a general rule
and put on dev.xwiki.org in the best practices section?
Thanks
-Vincent
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
