On 06/07/2012 03:25 AM, Vincent Massol wrote:
On Jun 7, 2012, at 9:24 AM, Vincent Massol wrote:
Hi Sergiu,
On Jun 7, 2012, at 12:51 AM, Sergiu Dumitriu wrote:
Hi devs,
Most of the devs know about the new xwiki-rendering engine which provides the
support for the new xwiki/2.x syntaxes, and the old Radeox-based rendering
engine which provides support for the xwiki/1.0 syntax, but I wonder who knows
about the Oro-based wikiwiki engine that provides support for an even older
undocumented wiki syntax? That one has been in the oldcore sources before I
came in contact with XWiki, and it has been disabled for a very long time.
One thing that we still use from that basic rendering engine is the support for
{pre}{/pre} code escaping, and that one will have to be preserved even if we
remove all the rest.
The advantages of removing it include:
- less ancient, unused, buggy code
-- thus slightly less PermGen memory required and faster startup
- one less Oro dependency (a long term goal is to remove Oro and ECS from our
dependencies)
- fewer WTFs from people stumbling over that code
Does anybody know of any users of that syntax? Is anybody still running 0.1.x
versions?
+1 but there's the risk of introducing errors in our rewritten pre support so
we would need to be careful.
Forgot to ask: can it be moved to legacy?
It could, but with great effort. That one is referenced from inside
com.xpn.xwiki.render.DefaultXWikiRenderingEngine.DefaultXWikiRenderingEngine(XWiki,
XWikiContext) in a long if-else chain. I'm not sure if the effort is
really worth.
Thanks
-Vincent
<off thread>
I'd personally like to go further and remove the oldcore xwiki syntax 1.0 part
completely and move it to legacy modules (which means still available for our
end users).
List of what would need to be done before we can move it to legacy:
- Some cleanup to use the new velocity module in a few places instead of the
old rendering for interpretText. I can think of templates and translations.
There are probably more places.
- Move our 21 pages from the stats app to xwiki/2.1 syntax
- Move XWiki.OfficeImporter and XWiki.WatchListMessage to xwiki/2.1 syntax
- anything else?
</off thread>
Thanks
-Vincent
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
