On Fri, Nov 1, 2013 at 10:11 AM, Vincent Massol <[email protected]> wrote:
> Forgot, +1 to bundle http://www.famfamfam.com/lab/icons/flags/
>

> Is it possible to have these flag images brought by one of the 
> xwiki-platform-localization modules in its JAR file?

I don't know how to reference the flags from the JAR file. There is
JSRX and SSRX but they are used to inject a script / link element in
the HTML page head. In my case I need to get image URL. And
getSkinFile doesn't look in JARs AFAIK.

Or do you mean keeping the flags in a localization module (JAR / WAR)
that is merged with the platform web WAR at build time?

Thanks,
Marius

>
> That would compartiment everything related to localization in one place.
>
> Thanks
> -Vincent
>
> On 01 Nov 2013, at 09:09, Vincent Massol <[email protected]> wrote:
>
>>
>> On 01 Nov 2013, at 08:58, Thomas Mortagne <[email protected]> wrote:
>>
>>> That's the icon set we use in l10n wiki so yes it's a good fit but
>>> note that having countries flags is one thing, matching them with
>>> languages codes in another.
>>
>> It would be pretty easy to maintain an internal mapping (in code) between a 
>> flag image name and a language code.
>>
>> Language codes are pretty much fixed and it should be easy to have that 
>> mapping.
>>
>> What am I missing?
>>
>> Thanks
>> -Vincent
>>
>>> An alternative is to export
>>> http://l10n.xwiki.org/xwiki/bin/view/L10N/Flags page and update it
>>> when we release new version like with translations.
>>>
>>> On Fri, Nov 1, 2013 at 8:36 AM, Marius Dumitru Florea
>>> <[email protected]> wrote:
>>>> Hi devs,
>>>>
>>>> In order to implement http://jira.xwiki.org/browse/XWIKI-9512 (display
>>>> the flag icon and the language pretty name instead of the language
>>>> code) I need to bundle a flag icon set in XE. The best option seems to
>>>> be http://www.famfamfam.com/lab/icons/flags/ . They say:
>>>>
>>>> "These flag icons are available for free use for any purpose with no
>>>> requirement for attribution."
>>>>
>>>> So if no one objects I'm going to add the PNG set to
>>>> xwiki-platform-web, in webapp/resources/icons/flags . It weights about
>>>> 130KB.
>>>>
>>>> The alternative is to display only the language pretty name, but it's
>>>> less nicer.
>>>>
>>>> Or maybe you know a better flag icon set.
>>>>
>>>> Thanks,
>>>> Marius
>>>> _______________________________________________
>>>> devs mailing list
>>>> [email protected]
>>>> http://lists.xwiki.org/mailman/listinfo/devs
>>>
>>>
>>>
>>> --
>>> Thomas Mortagne
>>> _______________________________________________
>>> devs mailing list
>>> [email protected]
>>> http://lists.xwiki.org/mailman/listinfo/devs
>>
>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to