+1 for contributor (If I'm allow to vote ;-) )
because identify/isolate issue + create/describe issue on jira + screenshot AND
find patch + test (almost) all usercaset + PR taking time and effort too :-)
Pascal B (a tiny contributor) :-)
De : Ecaterina Moraru (Valica) <[email protected]>
À : XWiki Developers <[email protected]>
Envoyé le : Mercredi 26 novembre 2014 14h57
Objet : Re: [xwiki-devs] [Vote] Assignee for PR: Contributor or Committer?
I'm +1 for Contributor (if the PR is complete).
Is kind of the committer's job to do the PR review and although this is
hard work :) encouraging the contributor in making more PRs and maybe then
voting him as committer is a nice strategy.
We can always see in the Commits tab who did the merge.
Thanks,
Caty
On Wed, Nov 26, 2014 at 3:44 PM, Jean SIMARD <[email protected]> wrote:
> +0
>
> On Wed, Nov 26, 2014 at 03:21:06PM +0200, Ecaterina Moraru (Valica) wrote:
> > Hi,
> >
> > We have discussed this subject multiple times, but we don't have an
> > official vote and conclusion on the topic.
> >
> > Problem: In JIRA who is the Assignee of an issue fixed by a Pull Request?
> > 1: Contributor
> > - he provided the solution
> > - giving the attributions, the contributor might feel encouraged to
> > contribute more
> > - we could do some JIRA statistics on external contributions, but this
> use
> > case can be covered by GitHub statistics
> >
> > 2: Committer
> > - he does the merging on his account and he becomes responsible for the
> > committed code.
> > - in case there are problems, the committer needs to find solution, since
> > we can't rely on contributors availability
> > - in doing the PR review, the committer spends a lot of time analyzing
> and
> > testing the provided solution
> >
> > We are talking here about complete solutions provided by the PR, since in
> > case of partial solutions, the committer can assign himself on the issue
> > (depends on the quantity of modification he does).
> >
> > Let me know what you think,
> > Caty
> > _______________________________________________
> > devs mailing list
> > [email protected]
> > http://lists.xwiki.org/mailman/listinfo/devs
>
> --
> Jean Simard
> [email protected]
> Research engineer at XWiki SAS
> http://www.xwiki.com
> Committer on the XWiki.org project
> http://www.xwiki.org
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
