This is not the first time we discuss that I had the impression it was ok for everyone to put 1: contributor.
It's very easy to know what committer applied the pull request and I feel that the issue should be assigned to who actually fixed/done what is described, there is never too much contribution rewards. On Wed, Nov 26, 2014 at 2:21 PM, Ecaterina Moraru (Valica) <[email protected]> wrote: > Hi, > > We have discussed this subject multiple times, but we don't have an > official vote and conclusion on the topic. > > Problem: In JIRA who is the Assignee of an issue fixed by a Pull Request? > 1: Contributor > - he provided the solution > - giving the attributions, the contributor might feel encouraged to > contribute more > - we could do some JIRA statistics on external contributions, but this use > case can be covered by GitHub statistics > > 2: Committer > - he does the merging on his account and he becomes responsible for the > committed code. > - in case there are problems, the committer needs to find solution, since > we can't rely on contributors availability > - in doing the PR review, the committer spends a lot of time analyzing and > testing the provided solution > > We are talking here about complete solutions provided by the PR, since in > case of partial solutions, the committer can assign himself on the issue > (depends on the quantity of modification he does). > > Let me know what you think, > Caty > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
