I agree with both actions. 2016-06-30 13:38 GMT+02:00 Ecaterina Moraru (Valica) <[email protected]>:
> I've created > http://jira.xwiki.org/browse/TOUR-41 Mark Tour.WebHome and Tour instances > as hidden > http://jira.xwiki.org/browse/TOUR-42 Modify the Homepage Livetable to > display Hidden pages > > Thanks, > Caty > > On Thu, Jun 30, 2016 at 2:25 PM, Vincent Massol <[email protected]> > wrote: > > > > > > On 30 Jun 2016, at 12:55, Ecaterina Moraru (Valica) <[email protected] > > > > wrote: > > > > > > Tour - some problems: > > > - Apparently making it hidden, makes it disappear from the Tour > > Livetable; > > > - Even if we mark the Homepage Tour as visible, in the Navigation panel > > we > > > still see Tour.WebHome > > > > > > So, we either: > > > 1. make as hidden all Tour instances + homepage (in order to not see it > > > from the Navigation panel) = in this case we consider the Tour app to > be > > a > > > technical app (meant to help the user, but not user content) > > > > > > 2. leave them as is, but in this case, by default, users will see an > > > additional space (Tour) + the Homepage Tour instance (which contains > CSS > > > selectors and steps) > > > > > > I would go with 1. > > > > I’d still make it hidden but just modify the Tour LT to display hidden > > pages… We already do that elsewhere and it’s very easy to do. > > > > Thanks > > -Vincent > > > > > Thanks, > > > Caty > > > > > > On Thu, Jun 30, 2016 at 12:41 PM, Vincent Massol <[email protected]> > > wrote: > > > > > >> > > >>> On 30 Jun 2016, at 11:33, Ecaterina Moraru (Valica) < > [email protected] > > > > > >> wrote: > > >>> > > >>> Questions about the Homepage Tour: > > >>> A. Should the Homepage Tour page be hidden or not? (I would say > hidden > > - > > >>> since it doesn't have content created by the user, it's some help to > > get > > >>> him started - he is able to dismiss it and not be bothered by it, so > > nit > > >>> sure why he should see it everytime in the Navigation panel) > > >>> B. Should we display the Tours app in AppBar? (I would say no - we > > tried > > >> to > > >>> limit to Blog/Dashboard/Sandbox which make sense for the end-user, > but > > >> Tour > > >>> could be something interesting just for Admins). > > >>> > > >>> WDTY? > > >> > > >> A - hidden (displayed in the tour app LT) > > >> B - No listed by default in the App panel > > >> > > >> Thanks > > >> -Vincent > > >> > > >>> Caty > > >>> > > >>> On Thu, Jun 30, 2016 at 12:31 PM, Ecaterina Moraru (Valica) < > > >>> [email protected]> wrote: > > >>> > > >>>> Could be also xwiki-enterprise-ui-help/xwiki-enterprise-ui-help-tour > > :) > > >>>> but for now I'm ok with xwiki-enterprise-tours. We will add more > > module > > >>>> structure when/if we will need. > > >>>> > > >>>> Thanks, > > >>>> Caty > > >>>> > > >>>> On Thu, Jun 30, 2016 at 12:30 PM, Vincent Massol < > [email protected]> > > >>>> wrote: > > >>>> > > >>>>> > > >>>>>> On 30 Jun 2016, at 11:16, Ecaterina Moraru (Valica) < > > >> [email protected]> > > >>>>> wrote: > > >>>>>> > > >>>>>> I would put it in xwiki-enterprise-ui-help > (xwiki-enterprise-ui-tour > > >> is > > >>>>> a > > >>>>>> solution too, although I would prefer to have a more generic > module > > >> that > > >>>>>> could have Tips&Tricks, maybe some local documentation, etc.) In > the > > >>>>> future > > >>>>>> we might add Tours for other use cases (like Managing Users, > > >> Customizing > > >>>>>> the Look&Feel, etc.) (and they are not really module dependent, > > since > > >>>>> they > > >>>>>> could span multiple modules, Homepage tour for example showcases > > >> Panels, > > >>>>>> Web Templates, etc.) > > >>>>>> > > >>>>>> xwiki-enterprise-ui-mainwiki should have a dependency to > > >>>>>> xwiki-entreprise-ui-help (or -tour). In the 'farm' case I think we > > >> need > > >>>>> to > > >>>>>> provide a custom tour that emphases the isolation or particular > > >> actions > > >>>>> and > > >>>>>> if we really want to put it in commons we need to particularly > check > > >> the > > >>>>>> 'farm' case, since it would be annoying to have the tour launch > > every > > >>>>> time > > >>>>>> you create a new subwiki. > > >>>>>> I'm fine to put the dependency in xwiki-enterprise-ui-commons for > > 8.2, > > >>>>> but > > >>>>>> we will need to fix it to cover the 'farm’. > > >>>>> > > >>>>> FTR I’m also fine with xwiki-enterprise-ui-help if the majority > > thinks > > >>>>> it’s better than xwiki-enterprise-ui-tour. Note that it makes a bit > > >> harder > > >>>>> to reuse in other flavors if it’s less specific (ie imagine that > the > > >> flavor > > >>>>> wants only to reuse the tour and not other stuff). > > >>>>> > > >>>>> Thanks > > >>>>> -Vincent > > >>>>> > > >>>>>> Thanks, > > >>>>>> Caty > > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> On Thu, Jun 30, 2016 at 11:30 AM, Vincent Massol < > > [email protected]> > > >>>>> wrote: > > >>>>>> > > >>>>>>> > > >>>>>>>> On 30 Jun 2016, at 10:29, Vincent Massol <[email protected]> > > >> wrote: > > >>>>>>>> > > >>>>>>>>> > > >>>>>>>>> On 30 Jun 2016, at 10:16, Guillaume Delhumeau < > > >>>>>>> [email protected]> wrote: > > >>>>>>>>> > > >>>>>>>>> I would put it in xwiki-enterprise-ui-tour(s) so we can easily > > >>>>> isolate > > >>>>>>> it > > >>>>>>>>> and other flavors can re-use it. > > >>>>>>>> > > >>>>>>>> Indeed that’s a good point. > > >>>>>>>> > > >>>>>>>> Actually, since the home page tour is not related to the home > page > > >>>>>>> content (correct?) and it’s just related to the skin, I think I > > would > > >>>>> even > > >>>>>>> put it in platform in the Help module (or better, in a submodule > of > > >> the > > >>>>>>> Help module: xwiki-platform-help-tour, and move > xwiki-platform-help > > >> as > > >>>>>>> xwiki-platform-help-syntax). > > >>>>>>>> > > >>>>>>>> WDYT? > > >>>>>>> > > >>>>>>> Hmm I retract this idea… The issue is that platform should not > > have a > > >>>>>>> dependency on the tour app even if it’s an indirect one. > > >>>>>>> > > >>>>>>> So +1 for xwiki-enterprise-ui-tour. > > >>>>>>> > > >>>>>>> Thanks > > >>>>>>> -Vincent > > >>>>>>> > > >>>>>>>> Thanks > > >>>>>>>> -Vincent > > >>>>>>>> > > >>>>>>>>> 2016-06-30 9:45 GMT+02:00 Vincent Massol <[email protected]>: > > >>>>>>>>> > > >>>>>>>>>> Hi Alex, > > >>>>>>>>>> > > >>>>>>>>>>> On 28 Jun 2016, at 13:43, Alexandru Cotiuga < > > >>>>>>> [email protected]> > > >>>>>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>> According to the new decided strategy in > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>> > > >>>>> > > >> > > > http://markmail.org/search/?q=[xwiki-devs]+[VOTE]+New+Strategy+for+the+XWiki+Github+Organization > > >>>>>>>>>> , > > >>>>>>>>>>> third-party extensions can by bundled in XWiki Enterprise. In > > >> some > > >>>>>>> cases, > > >>>>>>>>>>> we would need some content from those extension to be > available > > >> at > > >>>>>>> build > > >>>>>>>>>>> time. Where could we put it? > > >>>>>>>>>>> > > >>>>>>>>>>> Taking the Tour Application's example, which It is about to > be > > >>>>> added > > >>>>>>> in > > >>>>>>>>>> the > > >>>>>>>>>>> dependency management of xwiki-enterprise and inherited in > > >>>>>>>>>>> > > xwiki-enterprise/xwiki-enterprise-ui/xwiki-enterprise-ui-commons, > > >>>>> we > > >>>>>>>>>> could > > >>>>>>>>>>> have the following options: > > >>>>>>>>>>> > > >>>>>>>>>>> 1) xwiki-enterprise-ui-commons as a space Tours > > >>>>>>>>>>> 2) xwiki-enterprise-ui-wiki as a space Tours > > >>>>>>>>>>> 3) xwiki-enterprise-ui-mainwiki as a space Tours > > >>>>>>>>>>> 4) in a new child module of xwiki-enterprise.ui (looks like > > >> "help" > > >>>>>>>>>> keyword > > >>>>>>>>>>> would make sense: xwiki-enterprise-ui-help) which could be > used > > >> for > > >>>>>>>>>> future > > >>>>>>>>>>> cases > > >>>>>>>>>>> 5) in a new child module of xwiki-enterprise-ui having a > > specific > > >>>>> name > > >>>>>>>>>> for > > >>>>>>>>>>> tours. > > >>>>>>>>>> > > >>>>>>>>>> Indeed the Homepage tour should be part of the XE flavor. > > >>>>>>>>>> > > >>>>>>>>>> The question is: > > >>>>>>>>>> Do we want the tour to start on each subwiki home page? > > >>>>>>>>>> > > >>>>>>>>>> My opinion: > > >>>>>>>>>> * We should have the tour running on subwiki home pages only > > when > > >>>>> the > > >>>>>>>>>> subwiki is an isolated wiki (ie not in the use case of > > xwiki.org > > >>>>> for > > >>>>>>>>>> example but yes for the use case of myxwiki.org for example). > > >>>>>>>>>> > > >>>>>>>>>> So if we say that the homepage should be present for both main > > >> wiki > > >>>>> and > > >>>>>>>>>> subwiki (and only triggered in some cases for subwikis) then > it > > >>>>> makes > > >>>>>>> sense > > >>>>>>>>>> to have it in 1) (and not in 2) or 3)). > > >>>>>>>>>> > > >>>>>>>>>> We could do 4) or 5) in the future if there’s a need but for > now > > >> I’d > > >>>>>>> say > > >>>>>>>>>> 1). > > >>>>>>>>>> > > >>>>>>>>>> Thanks > > >>>>>>>>>> -Vincent > > >>>>>>>>>> > > >>>>>>>>>>> Could we decide a new rule for this topic? > > >>>>>>>>>>> > > >>>>>>>>>>> Thanks, > > >>>>>>>>>>> Alex > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
