Hi Simon and all, > On 5 Sep 2019, at 15:43, Simon Urli <simon.u...@xwiki.com> wrote: > > Hi everyone, > > reopening this thread since I started to close some flicker issues as part of > BFD and got comments for those. > > So the last mails on this threads suggested to close the flicker issues if we > didn't manage to reproduce them locally after a repeated tests, and that we > didn't see them after a while. > > We didn't vote for those suggestion and I assumed a bit quick that I could > close some flicker issues that I personally don't remember about on the CI > after having tested them locally. > My point for doing that is the same as for the first mail I posted on this > thread: those flickers are old, and the code did change enough for those to > be fixed in a way or another.
Well you didn’t say that in the comment when closing :) At least not for the one where I commented. I was just asking for a rationale, even asking what made you think that the flicker was gone. You said that you couldn’t reproduce locally but you didn’t say that the underlying code was also changed a lot (and I didn’t know that) ;) > Now I might be completely wrong, and the flicker to happen again, but I don't > think it's a problem since we can really easily open back the issues if it's > the case. > > The other solution IMO is to indeed keep the issue open and in fact to never > really close them, because we just don't have time to investigate each of > them properly. There’s another solution which is to check the history on the CI and close the issue as cannot reproduce if the flicker doesn’t reproduce *on the CI* (not locally since locally doesn’t prove anything since in 99.99% of the case the flicker couldn’t be reproduced locally and that’s why we marked it as a flicker :) Otherwise we would have fixed it!). Only potential issue is the size of the job history which is currently set to 10 executions and a bit too small to guarantee that the flicker doesn’t reproduce. EDIT: I see you mentioned a solution below > I really don't see any value of keeping things open and don't act on them, I definitely agree about that. We need to act on them. But closing is not acting on them. It’s quite the opposite. It’s about saying that we don’t care about them and we’re not going to do anything about them. Which means that we do test session days we won’t even look at them to try to fix the flicker since the issue would be closed. > that's why I suggest to close them after doing the checks we suggested before: > 1. try to repeat locally the failure; > 2. check that we didn't encounter those flickers since last cycle. > > So first question, do we all agree on that? The second point is the most important for me. But how do you plan to implement it (since the job history queue is only 10)? EDIT: I see you mentioned a solution below > Then for the second check, Vincent suggested to add some tooling: it will be > best, but it takes time to do. So on the meantime, as Thomas also suggested, > we could add a check in the release plan to create or update all jira issues > that concerns flickers. It would allow us to keep some information about the > liveness of our flickers. > > So second question, do you agree on that? Sounds like a good idea while waiting for a tool. > Final question: for the flickers that I closed today, I relied mainly on my > memory for the second check and on their age: I closed the older ones. > > So what should we do on them? I’m fine to trust you and to reopen when needed. I was just asking why you were closing them since you didn’t provide the info in comment. Thanks -Vincent > > Thanks, > Simon > > On 26/03/2019 10:58, Vincent Massol wrote: >>> On 26 Mar 2019, at 10:31, Simon Urli <simon.u...@xwiki.com> wrote: >>> >>> Hi everyone, >>> >>> I was checking our list of flickering tests in JIRA >>> (https://jira.xwiki.org/issues/?jql=labels%20%3D%20flickering%20AND%20status%20%3D%20Open%20ORDER%20BY%20updated%20DESC) >>> and I noticed that we had somehow old flickering test issue concerning >>> test that I've never seen failing. >>> >>> So I propose we close some of them as inactive: the ones that we don't >>> remember having seen for a while. The ideal would be to have a mechanism to >>> update the issue when the CI fails on a flicker, but it takes time to do >>> properly and it's not a priority. >>> >>> On the contrary I propose to trust our memory: if we're wrong because we >>> have closed a flicker that is still happening, it will allow us to remind >>> that we have this flicker to fix and we can easily reopen the issue. >>> >>> As Thomas mentioned on the chat, we should also update the release plan to >>> include the inactive flickers in the list of issue to check. >> I should be able to easily create a report when any test fails inside our >> jenkins pipeline and make it available similar to our clover report. I could >> indicate if it’s a known flicker or not too in this report. That could >> compensate for the fact that we only keep 7 days of records in our jobs. >> Would need to define the report format, whether it’s the same file updated >> at each run or a different one. If the same one, then either: >> * I’d need to parse it first in memory, add the new tests and overwrite the >> file >> * or add to the bottom of the file which will grow quite large quickly >> WDYT? >> Thanks >> -Vincent >>> >>> So for now I propose to close the following list of issues as inactive: >>> >>> * XWIKI-14399: AddRemoveTagsTest#addAndDeleteTagFromTagPage is flickering >>> (https://jira.xwiki.org/browse/XWIKI-14399) >>> * XWIKI-14396: AnnotationsTest#addAndDeleteAnnotations is flickering >>> (https://jira.xwiki.org/browse/XWIKI-14396) >>> * XWIKI-14394: SectionTest.testSectionEditInWikiEditorWhenSyntax2x >>> (xwiki-enterprise-test-ui) is flaky >>> (https://jira.xwiki.org/browse/XWIKI-14394) >>> * XWIKI-14386: appwithinminutes.AppsLiveTableTest.testEditApplication is >>> possibly flaky (https://jira.xwiki.org/browse/XWIKI-14386) >>> * XWIKI-14835: DeletePageTest#deletePageIsImpossibleWhenNoDeleteRights is >>> flickering (https://jira.xwiki.org/browse/XWIKI-14835) >>> * XWIKI-14860: LoginTest#testDataIsPreservedAfterLogin is flickering >>> (https://jira.xwiki.org/browse/XWIKI-14860) >>> >>> And I propose in general to close the flickers we don't remember having >>> seen after a cycle as inactive. >>> >>> WDYT? >>> >>> Simon >>> -- >>> Simon Urli >>> Software Engineer at XWiki SAS >>> simon.u...@xwiki.com >>> More about us at http://www.xwiki.com > > -- > Simon Urli > Software Engineer at XWiki SAS > simon.u...@xwiki.com > More about us at http://www.xwiki.com
