On 01/11/2018 2:35 AM, 12345swordy wrote:
On Wednesday, 31 October 2018 at 13:28:54 UTC, rikki cattermole wrote:
On 01/11/2018 2:25 AM, 12345swordy wrote:
On Wednesday, 31 October 2018 at 13:22:28 UTC, rikki cattermole wrote:
On 01/11/2018 2:16 AM, 12345swordy wrote:
[...]
We have been splitting Phobos modules up:
std.algorithm and most recently std.datetime
They were MASSIVE as in 30k+ LOC massive.
That's nice.
Again what consist of a module of being "too large"?
That seems to me that more of a art then a science.
Because it is.
My rules (which tend to be a little stricter than most peoples) are:
Soft split 1k LOC, hard split 3k LOC without a very good reason not to.
But at the end of the day, it just depends on the scope of the module.
Is it getting to large? If so, split.
Ok, you agree that it is subjective. Why is having more then one class
per file "too large"?
It doesn't. It is a group of related symbols. If it doesn't have
function bodies (e.g. extern(C++) or COM) I would call that module to
have too small of a scope.