On 3/9/14, 6:23 AM, Andrej Mitrovic wrote:
On 3/9/14, Vladimir Panteleev <[email protected]> wrote:
I don't think it was an intentional change, rather a mundane
regression. Could you post the affected code?

Breaking code wasn't intended.

On 3/9/14, Andrei Alexandrescu <[email protected]> wrote:
I wonder how we can improve the process to avoid such issues in the future.

The obvious answer is to have proper unittests. If the API broke, the
existing tests should have caught this. But the tests weren't touched
in the pull request, only new ones were added. What exactly broke
though?

Apparently direct use of the untagged union elements was not being unittested.

Andrei

Reply via email to