Quoting Ville Syrj�l�:
> The attached patch implements IDirectFBScreen::SetSourceLocation() and 
> includes the relevant changes to mach64 (lightly tested) and matrox 
> (untested) drivers.
> 
> I made it use ints instead of floats. That means that the source 
> rectangle needs to be reset when surface size changes. Using floats would 
> allow it to be recalculated. I'm not sure which is better.
> 
> Also I'm not sure about the method name. Set<something> would be 
> consistent with the other names. SetSourceLocation() isn't maybe the best 
> choice with int arguments (wrt. DFBLocation). So maybe it should be 
> SetSourceRectangle()?

SetSourceRectangle() sounds best so far. Would you like to commit that?

-- 
Best regards,
  Denis Oliver Kropp

.------------------------------------------.
| DirectFB - Hardware accelerated graphics |
| http://www.directfb.org/                 |
"------------------------------------------"

                            Convergence GmbH


Reply via email to