On Tue, Jun 22, 2004 at 09:36:48AM +0200, Denis Oliver Kropp wrote: > Quoting Ville Syrj�l�: > > The attached patch implements IDirectFBScreen::SetSourceLocation() and > > includes the relevant changes to mach64 (lightly tested) and matrox > > (untested) drivers. > > > > I made it use ints instead of floats. That means that the source > > rectangle needs to be reset when surface size changes. Using floats would > > allow it to be recalculated. I'm not sure which is better. > > > > Also I'm not sure about the method name. Set<something> would be > > consistent with the other names. SetSourceLocation() isn't maybe the best > > choice with int arguments (wrt. DFBLocation). So maybe it should be > > SetSourceRectangle()? > > SetSourceRectangle() sounds best so far. Would you like to commit that?
Done. Matrox changes are still untested but I'm fairly sure they're fine ;) I'm hoping some interested people might take a look at the other drivers. The required changes are quite simple stuff. But I think some of the drivers ignore cropping completely so some bigger changes may be warranted. -- Ville Syrj�l� [EMAIL PROTECTED] http://www.sci.fi/~syrjala/
