On Wed, Jul 28, 2004 at 12:35:54AM +0200, Stefan Lucke wrote:
> On Dienstag, 22. Juni 2004 21:24, Ville Syrj�l� wrote:
> > On Tue, Jun 22, 2004 at 09:36:48AM +0200, Denis Oliver Kropp wrote:
> > > Quoting Ville Syrj�l�:
> > > > The attached patch implements IDirectFBScreen::SetSourceLocation() and 
> > > > includes the relevant changes to mach64 (lightly tested) and matrox 
> > > > (untested) drivers.
> > > > 
> > > > I made it use ints instead of floats. That means that the source 
> > > > rectangle needs to be reset when surface size changes. Using floats would 
> > > > allow it to be recalculated. I'm not sure which is better.
> > > > 
> > > > Also I'm not sure about the method name. Set<something> would be 
> > > > consistent with the other names. SetSourceLocation() isn't maybe the best 
> > > > choice with int arguments (wrt. DFBLocation). So maybe it should be 
> > > > SetSourceRectangle()?
> > > 
> > > SetSourceRectangle() sounds best so far. Would you like to commit that?
> > 
> > Done. Matrox changes are still untested but I'm fairly sure they're 
> > fine ;)
> > 
> 
> Tried that with my matorx G550 and I get segfault 6: SetScreenLocation
> works still.

Did you try recompiling the application?

-- 
Ville Syrj�l�
[EMAIL PROTECTED]
http://www.sci.fi/~syrjala/


Reply via email to