tqchen commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404457389
##########
include/tvm/ffi/container/map.h:
##########
@@ -984,7 +984,9 @@ class DenseMapObj : public MapObj {
* \brief Check whether the hash table is full
* \return A boolean indicating whether hash table is full
*/
- bool IsFull() const { return size_ + 1 > NumSlots() * kMaxLoadFactor; }
+ bool IsFull() const {
+ return static_cast<double>(size_ + 1) > static_cast<double>(NumSlots()) *
kMaxLoadFactor;
Review Comment:
the comparison shuold not happn in double...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
