tqchen commented on code in PR #78: URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404218272
########## include/tvm/ffi/extra/json.h: ########## @@ -76,7 +76,7 @@ TVM_FFI_EXTRA_CXX_API json::Value Parse(const String& json_str, String* error_ms * \return The output JSON string. */ TVM_FFI_EXTRA_CXX_API String Stringify(const json::Value& value, - Optional<int> indent = std::nullopt); + const Optional<int>& indent = std::nullopt); Review Comment: change this would change ABI, and pas sby value is OK in this setting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
