tqchen commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404216910
##########
include/tvm/ffi/reflection/access_path.h:
##########
@@ -40,7 +41,7 @@ namespace reflection {
/*!
* \brief The kind of the access pattern.
*/
-enum class AccessKind : int32_t {
+enum class AccessKind : std::uint8_t {
Review Comment:
i think this is not something we should do, mainly for ABI stability and
chance of future growth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
