tqchen commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2405948818
##########
include/tvm/ffi/container/tensor.h:
##########
@@ -335,8 +335,8 @@ class Tensor : public ObjectRef {
* \param device The device of the Tensor.
* \return The created Tensor.
*/
- static Tensor FromDLPackAlloc(DLPackTensorAllocator allocator, ffi::Shape
shape, DLDataType dtype,
- DLDevice device) {
+ static Tensor FromDLPackAlloc(DLPackTensorAllocator allocator, const
ffi::Shape& shape,
Review Comment:
this should change to ffi::ShapeView shape
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
