junrushao commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404742239
##########
cmake/Utils/AddLibbacktrace.cmake:
##########
@@ -62,8 +62,9 @@ function (_libbacktrace_compile)
add_library(libbacktrace STATIC IMPORTED)
add_dependencies(libbacktrace project_libbacktrace)
set_target_properties(
- libbacktrace PROPERTIES IMPORTED_LOCATION
${libbacktrace_prefix}/lib/libbacktrace.a
- INTERFACE_INCLUDE_DIRECTORIES
${libbacktrace_prefix}/include
+ libbacktrace
+ PROPERTIES IMPORTED_LOCATION ${libbacktrace_prefix}/lib/libbacktrace.a
+ INTERFACE_INCLUDE_DIRECTORIES
${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace/
Review Comment:
This change is needed so that clang-tidy is able to find `backtrace.h`
statically with `compile_commands.json` without having to build the target
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
